RFR: 8311946: add support for libgraal specific jtreg tests [v3]
Doug Simon
dnsimon at openjdk.org
Thu Jul 13 09:52:05 UTC 2023
On Thu, 13 Jul 2023 09:48:24 GMT, Doug Simon <dnsimon at openjdk.org> wrote:
>> This PR adds support for `vm.libgraal` and `vm.libgraal.enabled` properties that can be used with the jtreg `@requires` tag to determine if a libgraal specific test should run.
>>
>> * `vm.libgraal`: the libgraal shared library file is present
>> * `vm.libgraal.enabled`: libgraal is used as JIT compiler
>
> Doug Simon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - add support for vm.libgraal property and fix problems with vm.libgraal.enabled property
> - Merge remote-tracking branch 'openjdk-jdk/master' into JDK-8311946
> - fix wrong flag name
> - add support for vm.libgraal.enabled property
I have pushed further changes to fix a bug (`vm.libgraal.enabled` was returning `VMProps.isGraalEnabled()`) and to add the `vm.libgraal` property. The latter is actually what one mostly often wants as it lets libgraal specific tests run on a JDK that includes libgraal but does not enable it by default without having to put `TEST_OPTS=JAVA_OPTIONS="-XX:+UnlockExperimentalVMOptions -XX:+UseJVMCICompiler` on the `make test` command line.
Please re-review in light of these changes.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14851#issuecomment-1633922569
More information about the hotspot-dev
mailing list