RFR: 8311946: add support for libgraal specific jtreg tests [v3]
Vladimir Kozlov
kvn at openjdk.org
Thu Jul 13 20:54:54 UTC 2023
On Thu, 13 Jul 2023 19:18:47 GMT, Doug Simon <dnsimon at openjdk.org> wrote:
>> I would prefer naming similar to "vm.hasJFR", "vm.hasSA", "vm.hasDTrace". It is unfortunate that we used "vm.jvmci" and "vm.jvmti" naming to check presence of features.
>>
>> Also libgraal is not part of VM. May be you need to use "jdk.hasLibgraal". There are other properties which use "jdk." already.
>
> Ok, `hasLibgraal` is fine.
> In what sense is libgraal not part of the VM? I would have thought that a JIT compiler is more "vm" than "jdk"?
In a sense that the libgraal **file** is separate from VM and its generation is not part of HotSpot VM build.
`hasLibgraal` property checks the presence of this separate file and not a feature which is part of VM build (like jvmci).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14851#discussion_r1263041686
More information about the hotspot-dev
mailing list