RFR: 8311130: AArch64: Sync SVE related CPU features with VM options
Andrew Haley
aph at openjdk.org
Mon Jul 17 08:54:13 UTC 2023
On Mon, 17 Jul 2023 03:19:10 GMT, Pengfei Li <pli at openjdk.org> wrote:
> As discussed in PR #14533, keeping AArch64 flag `UseSVE` and its related CPU features in sync helps to simplify rules in IR tests. In this patch, we mask SVE related CPU features off if specified SVE level in VM option is lower than the hardware supported. Also, to support this change, we move the features string construction to the end of the `initialize()` function.
>
> We also revert IR rule changes in PR #14533 and fix some code styles. We tested almost full jtreg on SVE, SVE2 and non-SVE CPUs and no new issue is found after this patch.
src/hotspot/cpu/aarch64/vm_version_aarch64.cpp line 211:
> 209: if (_cpu == CPU_ARM && ((_model == 0xd0c || _model2 == 0xd0c) ||
> 210: (_model == 0xd49 || _model2 == 0xd49) ||
> 211: (_model == 0xd40 || _model2 == 0xd40))) {
Perhaps we need a function to encapsulate the logic here.
bool model_is(unsigned in cpu_model) {
return _model == cpu_model || _model2 == cpu_model;
}
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14897#discussion_r1265058828
More information about the hotspot-dev
mailing list