RFR: 8311130: AArch64: Sync SVE related CPU features with VM options [v2]

Pengfei Li pli at openjdk.org
Tue Jul 18 09:01:30 UTC 2023


On Mon, 17 Jul 2023 08:51:19 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Pengfei Li has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Simplify some checks
>>  - Address aph's comment
>
> src/hotspot/cpu/aarch64/vm_version_aarch64.cpp line 211:
> 
>> 209:   if (_cpu == CPU_ARM && ((_model == 0xd0c || _model2 == 0xd0c) ||
>> 210:                           (_model == 0xd49 || _model2 == 0xd49) ||
>> 211:                           (_model == 0xd40 || _model2 == 0xd40))) {
> 
> Perhaps we need a function to encapsulate the logic here.
> 
> 
> bool model_is(unsigned in cpu_model) {
>     return _model == cpu_model || _model2 == cpu_model;
> }

I have addressed this in a new commit. Thanks for suggestion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14897#discussion_r1266459146


More information about the hotspot-dev mailing list