RFR: 8312014: [s390x] TestSigInfoInHsErrFile.java Failure [v4]

[Amit Kumar]

On Tue, 18 Jul 2023 17:21:46 GMT, sid8606 <duke at openjdk.org> wrote:

>> All faults on s390x give the address only on page granularity.
>> e.g. if you use 0x123456 as fail address you get si_addr = 0x123000
>
> sid8606 has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix #ifdef AIX

Changes requested by amitkumar (Committer).

src/hotspot/cpu/s390/globalDefinitions_s390.hpp line 34:

> 32: 
> 33: //All faults on s390x give the address only on page granularity.
> 34: //Set Pdsegfault_address to minumum one page address.

Suggestion:

// All faults on s390x give the address only on page granularity.
// Set pd_segfault_address to minimum one page address.

test/hotspot/jtreg/runtime/ErrorHandling/TestSigInfoInHsErrFile.java line 73:

> 71:     //All faults on s390x give the address only on page granularity.
> 72:     //Hence fault address is first page address.
> 73:     String crashAddress = Platform.isAix() ? "0xffffffffffffffff" : Platform.isS390x() ? "0x0*1000" : "0x0*400";

Probably we can create a if-else ladder here and move this comment inside that if/else block ? something like this: 

if (AIX) {
crashAddress for AIX
} else if (S390) {
// your comment
crashAddress for S390
} else {
crashAddress for other archs
}

-------------

PR Review: https://git.openjdk.org/jdk/pull/14888#pullrequestreview-1535568302
PR Review Comment: https://git.openjdk.org/jdk/pull/14888#discussion_r1267111048
PR Review Comment: https://git.openjdk.org/jdk/pull/14888#discussion_r1267102169