RFR: 8312014: [s390x] TestSigInfoInHsErrFile.java Failure [v4]

[sid8606]

On Tue, 18 Jul 2023 17:39:28 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> sid8606 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix #ifdef AIX
>
> src/hotspot/cpu/s390/globalDefinitions_s390.hpp line 34:
> 
>> 32: 
>> 33: //All faults on s390x give the address only on page granularity.
>> 34: //Set Pdsegfault_address to minumum one page address.
> 
> Suggestion:
> 
> // All faults on s390x give the address only on page granularity.
> // Set pd_segfault_address to minimum one page address.

Fixed, Thanks

> test/hotspot/jtreg/runtime/ErrorHandling/TestSigInfoInHsErrFile.java line 73:
> 
>> 71:     //All faults on s390x give the address only on page granularity.
>> 72:     //Hence fault address is first page address.
>> 73:     String crashAddress = Platform.isAix() ? "0xffffffffffffffff" : Platform.isS390x() ? "0x0*1000" : "0x0*400";
> 
> Probably we can create a if-else ladder here and move this comment inside that if/else block ? something like this: 
> 
> if (AIX) {
> crashAddress for AIX
> } else if (S390) {
> // your comment
> crashAddress for S390
> } else {
> crashAddress for other archs
> }

I have adapted this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14888#discussion_r1267533348
PR Review Comment: https://git.openjdk.org/jdk/pull/14888#discussion_r1267533250