RFR: 8301996: Move field resolution information out of the cpCache [v10]

Martin Doerr mdoerr at openjdk.org
Sat Jul 22 13:07:57 UTC 2023


On Fri, 21 Jul 2023 21:14:17 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> 8301996: Move field resolution information out of the cpCache
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Missing semicolon

src/hotspot/cpu/riscv/templateTable_riscv.cpp line 180:

> 178:       }
> 179:       // Load-acquire the bytecode to match store-release in ResolvedFieldEntry::fill_in()
> 180:       __ membar(MacroAssembler::AnyAny);

Why do you need this membar?

src/hotspot/cpu/riscv/templateTable_riscv.cpp line 2219:

> 2217:   }
> 2218:   // Load-acquire the bytecode to match store-release in ResolvedFieldEntry::fill_in()
> 2219:   __ membar(MacroAssembler::AnyAny);

Same here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14129#discussion_r1271294236
PR Review Comment: https://git.openjdk.org/jdk/pull/14129#discussion_r1271294300


More information about the hotspot-dev mailing list