RFR: 8301996: Move field resolution information out of the cpCache [v10]

Matias Saavedra Silva matsaave at openjdk.org
Tue Jul 25 15:28:56 UTC 2023


On Sun, 23 Jul 2023 23:04:32 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> src/hotspot/share/oops/resolvedFieldEntry.hpp line 125:
>> 
>>> 123:     _tos = tos;
>>> 124: 
>>> 125:     // This has to be done last
>> 
>> Maybe better use `OrderAccess::release()` here instead of 2x `Atomic::release_store` above? That would fit to the comment.
>
> Is the comment accurate? The semantics would be different. Does seeing the update to `_put_code` require that the update to `_get_code` is also seen?

The comment seems to be unclear so I will update it. The fields `_get_code` and `_put_code` do not require the other to be seen, they just have to be set after all of the other fields.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14129#discussion_r1273726943


More information about the hotspot-dev mailing list