RFR: 8301996: Move field resolution information out of the cpCache [v10]
David Holmes
dholmes at openjdk.org
Sun Jul 23 23:07:58 UTC 2023
On Sat, 22 Jul 2023 13:11:53 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Missing semicolon
>
> src/hotspot/share/oops/resolvedFieldEntry.hpp line 125:
>
>> 123: _tos = tos;
>> 124:
>> 125: // This has to be done last
>
> Maybe better use `OrderAccess::release()` here instead of 2x `Atomic::release_store` above? That would fit to the comment.
Is the comment accurate? The semantics would be different. Does seeing the update to `_put_code` require that the update to `_get_code` is also seen?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14129#discussion_r1271573904
More information about the hotspot-dev
mailing list