RFR: 8312262: Klass::array_klass() should return ArrayKlass pointer [v2]

[Coleen Phillimore]

On Thu, 27 Jul 2023 21:43:59 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Calvin's suggestions and remove set_higher_dimension.
>
> src/hotspot/share/oops/arrayKlass.cpp line 130:
> 
>> 128:   check_array_allocation_length(length, arrayOopDesc::max_array_length(T_ARRAY), CHECK_NULL);
>> 129:   size_t size = objArrayOopDesc::object_size(length);
>> 130:   ArrayKlass* ak = array_klass(n+dimension(), CHECK_NULL);
> 
> Please add a blank space before and after the '+'.

ok

> src/hotspot/share/oops/objArrayKlass.cpp line 179:
> 
>> 177:     if (length != 0) {
>> 178:       for (int index = 0; index < length; index++) {
>> 179:         oop sub_array = ld_klass->multi_allocate(rank-1, &sizes[1], CHECK_NULL);
> 
> Please add a blank space before and after the '-'.

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15059#discussion_r1276887177
PR Review Comment: https://git.openjdk.org/jdk/pull/15059#discussion_r1276887382