src/hotspot/share/adlc/formsopt.cpp: FrameForm constructor does not initialise all the members

Vladimir Petko vladimir.petko at canonical.com
Thu Jun 8 22:12:49 UTC 2023


Dear Maintainers,

 src/hotspot/share/adlc/formsopt.cpp contains the FrameForm()
constructor that does not initialise all of its members. Would it be
possible to consider a patch that fixes FrameForm initialisation?
Alternatively this class could benefit from adding default member
initialisers, e.g.
--------cut------------
class FrameForm : public Form {
private:

public:
// Public Data
char *_sync_stack_slots{};
char *_inline_cache_reg{};
....
----------cut--------------
and removing initialisation from the constructor.
 In this case it would be harder to leave a new member uninitialised
and it would be immediately obvious.

Best Regards,
  Vladimir.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: formopt.cpp.patch
Type: text/x-patch
Size: 727 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/hotspot-dev/attachments/20230609/ca0ac73a/formopt.cpp.patch>


More information about the hotspot-dev mailing list