RFR: 8306028: separate ThreadStart/ThreadEnd events posting code in JVMTI VTMS transitions [v8]

Serguei Spitsyn sspitsyn at openjdk.org
Fri Jun 9 05:15:56 UTC 2023


On Thu, 8 Jun 2023 19:05:54 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update copyright comments
>
> src/hotspot/share/runtime/sharedRuntime.cpp line 641:
> 
>> 639: JRT_ENTRY(void, SharedRuntime::notify_jvmti_vthread_start(oopDesc* vt, jboolean hide, JavaThread* current))
>> 640:   assert(hide == JNI_FALSE, "must be VTMS transition finish");
>> 641:   jobject vthread = JNIHandles::make_local(const_cast<oopDesc*>(vt));
> 
> Since the current thread is in the `current` arg, it could be used here when creating the local handle.

That's right. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13484#discussion_r1223851214


More information about the hotspot-dev mailing list