RFR: 8309613: [Windows] hs_err files sometimes miss information about the code containing the error

[David Holmes]

On Thu, 8 Jun 2023 09:32:00 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> src/hotspot/share/utilities/vmError.cpp line 680:
>> 
>>> 678:   // keep track of which code has already been printed
>>> 679:   const int printed_capacity = max_error_log_print_code;
>>> 680:   address printed[printed_capacity];
>> 
>> Does this buffer get reused/overwritten by the "printing code blobs" logic?
>
> The purpose of the buffer is to keep track of what has already been printed. We don't want to print the same code again if we encounter the address again. This can be used across several error reporting steps.

Okay, I just wanted to make sure the different usages don't interfere with each other.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14358#discussion_r1223820488