RFR: 8309613: [Windows] hs_err files sometimes miss information about the code containing the error [v2]

Martin Doerr mdoerr at openjdk.org
Fri Jun 9 10:24:10 UTC 2023


On Thu, 8 Jun 2023 02:10:49 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Check result of print_code and update printed_len.
>
> src/hotspot/share/utilities/vmError.cpp line 976:
> 
>> 974:       // We have printed the native stack in platform-specific code
>> 975:       // Windows/x64 needs special handling.
>> 976:       // Stack walking may got stuck. Try to print the calling code.
> 
> Nit: s/got/get/

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14358#discussion_r1224127180


More information about the hotspot-dev mailing list