RFR: 8309613: [Windows] hs_err files sometimes miss information about the code containing the error [v3]

Thomas Stuefe stuefe at openjdk.org
Tue Jun 13 06:10:58 UTC 2023


On Tue, 13 Jun 2023 02:29:04 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move parts to step which prints code blobs
>
> src/hotspot/share/utilities/vmError.cpp line 998:
> 
>> 996:         const char* name = find_code_name(lastpc);
>> 997:         if (name != nullptr) {
>> 998:           st->print_cr("the last pc belongs to %s (will be printed below)", name);
> 
> s/the/The
> s/will be//

Why not print the nmethod right here?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14358#discussion_r1227569666


More information about the hotspot-dev mailing list