RFR: 8309613: [Windows] hs_err files sometimes miss information about the code containing the error [v3]

[David Holmes]

On Tue, 13 Jun 2023 06:02:16 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> src/hotspot/share/utilities/vmError.cpp line 998:
>> 
>>> 996:         const char* name = find_code_name(lastpc);
>>> 997:         if (name != nullptr) {
>>> 998:           st->print_cr("the last pc belongs to %s (will be printed below)", name);
>> 
>> s/the/The
>> s/will be//
>
> Why not print the nmethod right here?

See my earlier comments. I was looking for some kind of delineation of all this additional stuff so that it would be easier to see where it fits into things. Not sure we've really achieved that regardless.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14358#discussion_r1227701172