RFR: 8309974: some JVMCI tests fails when VM options include -XX:+EnableJVMCI

[David Holmes]

On Wed, 14 Jun 2023 20:04:41 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

> This PR fixes a few JVMCI tests to run the `ClassFileInstaller` step with `@run main/othervm` instead of `@run driver` so that it inherits extra VM options passed to jtreg. This is required for these tests as they use JVMCI and module exports are needed when running `ClassFileInstaller` on the test class itself.
> 
> Thanks to @jonathan-gibbons for providing this solution.

I must admit I am surprised by this situation. I never imagined that `@module` directives would also be applied to the action to run the `ClassfileInstaller` as it should not need anything of that kind - it is just a simple file copying utility. But I can see how jtreg has no way to know that. Makes me wonder though whether `@modules` should only ever be applied to `main/othervm`? We not only recommend using driver mode for `ClassfileInstaller` we actively went through and changed a number of tests to do that!

So the fix seems fine in so far as the situation we have today, but I'm not convinced there isn't a jtreg issue here that needs further examination.

Thanks.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14476#pullrequestreview-1480575784