RFR: 8309974: some JVMCI tests fails when VM options include -XX:+EnableJVMCI
Doug Simon
dnsimon at openjdk.org
Thu Jun 15 07:24:55 UTC 2023
On Thu, 15 Jun 2023 02:48:55 GMT, David Holmes <dholmes at openjdk.org> wrote:
> I must admit I am surprised by this situation. I never imagined that `@module` directives would also be applied to the action to run the `ClassfileInstaller` as it should not need anything of that kind - it is just a simple file copying utility. But I can see how jtreg has no way to know that. Makes me wonder though whether `@modules` should only ever be applied to `main/othervm`? We not only recommend using driver mode for `ClassfileInstaller` we actively went through and changed a number of tests to do that!
>
> So the fix seems fine in so far as the situation we have today, but I'm not convinced there isn't a jtreg issue here that needs further examination.
>
> Thanks.
To be honest, it's still unclear to me why passing the extra VM options `-XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCI` to jtreg (via the `TEST_OPTS=VM_OPTIONS` make control variable) causes this problem. That seems like it should be unrelated as to whether jtreg applies `@module` to a driver command. In any case, @jonathan-gibbons understands the jtreg issue and is taking care of it.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14476#issuecomment-1592500518
More information about the hotspot-dev
mailing list