RFR: 8310170: Use sp's argument to improve performance of outputStream::indent

David Holmes dholmes at openjdk.org
Mon Jun 19 01:13:19 UTC 2023


On Thu, 15 Jun 2023 20:50:11 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Hi,
> 
> Please consider this small enhancement. `sp` takes a count argument, this was never used by `indent`, let's just use it.

There's potentially a subtle difference in behaviour here if SP_USE_TABS were ever true - but as it is defined to be false there is no difference in practice. Maybe we should just cull the code related to SP_USE_TABS and not pretend we could do something different here?

Thanks.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14502#pullrequestreview-1485258186


More information about the hotspot-dev mailing list