RFR: 8310332: Fix -Wconversion warnings in MethodData [v2]
Coleen Phillimore
coleenp at openjdk.org
Tue Jun 20 13:23:10 UTC 2023
On Tue, 20 Jun 2023 12:56:07 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> src/hotspot/share/oops/methodData.cpp line 483:
>>
>>> 481: for (uint row = 0; row < row_limit(); row++) {
>>> 482: if (bci(row) == no_bci) {
>>> 483: set_bci_displacement(row, (int)(mdp - dp()));
>>
>> `checked_cast` here?
>
> I picked a straight cast because dp() is the address of _data inside this mdp, but now I'm not so sure. I'll change this one.
I reran tier1 tests on the change, just to be sure.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14557#discussion_r1235255321
More information about the hotspot-dev
mailing list