RFR: 8310332: Fix -Wconversion warnings in MethodData [v3]

Coleen Phillimore coleenp at openjdk.org
Wed Jun 21 18:01:15 UTC 2023


On Wed, 21 Jun 2023 12:11:08 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Please review this change to narrow parameter and return types to avoid implicit casts, add casts where obvious, add checked_cast<> where not obvious and changed the size of a couple parameters to not cast to the smaller size.
>> I didn't change TypeProfileWidth and BciProfileWidth because jvmci and SA care about the sizes.
>> Tested tier1 all Oracle supported platforms, and tier1-4 linux + windows x64.
>
> Coleen Phillimore has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into md-conversion
>  - Add a checked_cast<>
>  - Fix -Wconversion warnings in methodData

Thank you Andrew and Fred for reviewing.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14557#issuecomment-1601324399


More information about the hotspot-dev mailing list