RFR: 8310494: Do not include constantPool.hpp from instanceKlass.hpp [v2]

[Stefan Karlsson]

On Thu, 22 Jun 2023 03:16:19 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> instanceKlass.hpp is needed quite frequently for HotSpot C++ sources, but constantPool.hpp is much less frequently.
>> 
>> This PR is the first step of reducing the inclusion of constantPool.hpp, by removing it from instanceKlass.hpp
>> 
>> I moved a bunch of inline functions into instanceKlass.cpp. These don't seem to be performance related.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @stefank review comments

Reviewed. Left some nits that you could consider.

src/hotspot/share/oops/instanceKlass.hpp line 996:

> 994:   // The constant pool is on stack if any of the methods are executing or
> 995:   // referenced by handles.
> 996:   virtual bool on_stack() const;

The comment looks weird now that the implementation, which delegates to the constant pool, has been moved from the header. I think the comment needs to be updated.

-------------

Marked as reviewed by stefank (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14597#pullrequestreview-1492578541
PR Review Comment: https://git.openjdk.org/jdk/pull/14597#discussion_r1238135814