RFR: 8310494: Do not include constantPool.hpp from instanceKlass.hpp [v2]

Thu Jun 22 11:48:05 UTC 2023

On Thu, 22 Jun 2023 07:45:38 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @stefank review comments
>
> src/hotspot/share/oops/instanceKlass.hpp line 996:
> 
>> 994:   // The constant pool is on stack if any of the methods are executing or
>> 995:   // referenced by handles.
>> 996:   virtual bool on_stack() const;
> 
> The comment looks weird now that the implementation, which delegates to the constant pool, has been moved from the header. I think the comment needs to be updated.

Suggest move the comment to the implementation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14597#discussion_r1238411597