RFR: 8310906: Fix -Wconversion warnings in runtime, oops and some code header files. [v3]

[Stefan Karlsson]

On Tue, 27 Jun 2023 15:11:34 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Hm.  Maybe this would be ok. Our original idea was to make it T* not T until this cast.  I don't know how many other cases there are that I haven't gotten to yet.  But it would eliminate a cast, so that's good (unless these aren't the same).  Some instances have ptr - constant that gets promoted I think.
>> The reason we didn't pick pointer_delta_as_int because pointer_delta has different semantics.  pointer_delta insists on positive results.
>
> Taking out that cast does work, so I've fixed that.

> pointer_delta has different semantics

Right. That was "recently" added to pointer_delta with JDK-8260046. It begs the question why felt the need to add it there but feel that it is OK to skip it for delta_as_int? Is there some usage of delta_as_int that gives back negative values? Could that call site be changed?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14675#discussion_r1244829942