RFR: 8310906: Fix -Wconversion warnings in runtime, oops and some code header files. [v3]

[Coleen Phillimore]

On Wed, 28 Jun 2023 07:52:35 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Taking out that cast does work, so I've fixed that.
>
>> pointer_delta has different semantics
> 
> Right. That was "recently" added to pointer_delta with JDK-8260046. It begs the question why felt the need to add it there but feel that it is OK to skip it for delta_as_int? Is there some usage of delta_as_int that gives back negative values? Could that call site be changed?

There are sites where the result is negative but this is a good suggestion because it makes the name more consistent.  I can change those to plain check_cast<int>s.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14675#discussion_r1245141370