RFR: 8311074: RISC-V: Fix -Wconversion warnings in some code header files
Fei Yang
fyang at openjdk.org
Thu Jun 29 01:50:55 UTC 2023
On Thu, 29 Jun 2023 00:52:49 GMT, Gui Cao <gcao at openjdk.org> wrote:
> Hi, refer to the modification of aarch64 in https://github.com/openjdk/jdk/pull/14675 , here is the riscv version, before this PR has the same -Wconversion warnings as aarch64, after this this PR the -Wconversion warnings has been eliminated.
> Please take a look and have some reviews. Thanks a lot.
>
> ## Testing:
> - [x] Tier1 tests (release)
Marked as reviewed by fyang (Reviewer).
src/hotspot/cpu/riscv/stackChunkFrameStream_riscv.inline.hpp line 118:
> 116: + 1 // for the mirror oop
> 117: + pointer_delta_as_int((intptr_t*)f.interpreter_frame_monitor_begin(),
> 118: (intptr_t*)f.interpreter_frame_monitor_end())/BasicObjectLock::size();
Nit: I think you should keep the surrounding spaces for `/`
-------------
PR Review: https://git.openjdk.org/jdk/pull/14702#pullrequestreview-1504445004
PR Review Comment: https://git.openjdk.org/jdk/pull/14702#discussion_r1245996777
More information about the hotspot-dev
mailing list