RFR: 8311074: RISC-V: Fix -Wconversion warnings in some code header files [v2]

Gui Cao gcao at openjdk.org
Thu Jun 29 02:05:05 UTC 2023


On Thu, 29 Jun 2023 01:47:38 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Gui Cao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Keep the surrounding spaces for /
>
> src/hotspot/cpu/riscv/stackChunkFrameStream_riscv.inline.hpp line 118:
> 
>> 116:         + 1 // for the mirror oop
>> 117:         + pointer_delta_as_int((intptr_t*)f.interpreter_frame_monitor_begin(),
>> 118:               (intptr_t*)f.interpreter_frame_monitor_end())/BasicObjectLock::size();
> 
> Nit: I think you should keep the surrounding spaces for `/`

Thanks for your review, fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14702#discussion_r1246004009


More information about the hotspot-dev mailing list