RFR: 8301996: Move field resolution information out of the cpCache [v2]

[Dingli Zhang]

On Thu, 29 Jun 2023 15:44:27 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> 8301996: Move field resolution information out of the cpCache
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Coleen and Amit comments

>From the cursory review, with some comments.

src/hotspot/cpu/aarch64/templateTable_aarch64.cpp line 2553:

> 2551:   if (!CompilerConfig::is_c1_or_interpreter_only_no_jvmci()){
> 2552:     Label notVolatile;
> 2553:     __ andr(raw_flags, raw_flags, 0x1);

It looks like `andr` is not needed here?

src/hotspot/cpu/aarch64/templateTable_aarch64.cpp line 2774:

> 2772:   {
> 2773:     Label notVolatile;
> 2774:     __ andr(r5, r5, 0x1);

Same here.

src/hotspot/cpu/aarch64/templateTable_aarch64.cpp line 3026:

> 3024:   load_resolved_field_entry(r2, r2, r0, r1, r3);
> 3025:   // Test for volatile
> 3026:   __ andr(r3, r3, 0x1);

Same here.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14129#pullrequestreview-1506783520
PR Review Comment: https://git.openjdk.org/jdk/pull/14129#discussion_r1247610990
PR Review Comment: https://git.openjdk.org/jdk/pull/14129#discussion_r1247612386
PR Review Comment: https://git.openjdk.org/jdk/pull/14129#discussion_r1247612542