RFR: 8301996: Move field resolution information out of the cpCache [v2]

Matias Saavedra Silva matsaave at openjdk.org
Fri Jun 30 14:42:55 UTC 2023


On Fri, 30 Jun 2023 08:47:52 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Coleen and Amit comments
>
> src/hotspot/cpu/aarch64/templateTable_aarch64.cpp line 2553:
> 
>> 2551:   if (!CompilerConfig::is_c1_or_interpreter_only_no_jvmci()){
>> 2552:     Label notVolatile;
>> 2553:     __ andr(raw_flags, raw_flags, 0x1);
> 
> It looks like `andr` is not needed here?

I believe `andr` is still necessary here since `raw_flags` has two bits that are used. The is_volatile flag may be false but if is_final is true, the flag will not be zero without the and.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14129#discussion_r1247947452


More information about the hotspot-dev mailing list