RFR: 8301996: Move field resolution information out of the cpCache [v2]

Dingli Zhang dzhang at openjdk.org
Fri Jun 30 09:29:03 UTC 2023


On Thu, 29 Jun 2023 15:44:27 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> 8301996: Move field resolution information out of the cpCache
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Coleen and Amit comments

src/hotspot/cpu/aarch64/templateTable_aarch64.cpp line 3137:

> 3135:   if (!CompilerConfig::is_c1_or_interpreter_only_no_jvmci()) {
> 3136:     Label notVolatile;
> 3137:     __ andr(r3, r3, 0x1);

Same here.

src/hotspot/cpu/aarch64/templateTable_aarch64.cpp line 3200:

> 3198:     Label notVolatile;
> 3199:     __ load_unsigned_byte(r3, Address(r2, in_bytes(ResolvedFieldEntry::flags_offset())));
> 3200:     __ andr(r3, r3, 0x1);

Same here.

src/hotspot/cpu/aarch64/templateTable_aarch64.cpp line 3228:

> 3226:     Label notVolatile;
> 3227:     __ load_unsigned_byte(r3, Address(r2, in_bytes(ResolvedFieldEntry::flags_offset())));
> 3228:     __ andr(r3, r3, 0x1);

Same here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14129#discussion_r1247656326
PR Review Comment: https://git.openjdk.org/jdk/pull/14129#discussion_r1247656464
PR Review Comment: https://git.openjdk.org/jdk/pull/14129#discussion_r1247656560


More information about the hotspot-dev mailing list