RFR: JDK-8302989: Add missing INCLUDE_CDS checks [v2]

[Ioi Lam]

On Thu, 2 Mar 2023 16:27:32 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> You need to remove the `extern` keyword, and add the definition of `= false` in globalDefinitions.hpp.
>> 
>> Then, the corresponding definition should be removed from globalDefinitions.cpp.
>
> Hi Ioi, I adjusted the *SharedSpaces in  globalDefinitions.cpp / globalDefinitions.hpp  .

I am on vacation now so I won’t be able to follow up with the review. Please feel free to integrate after you get enough reviews.

Just a general comment. For blocks that are enclosed with “if (UseSharedSpace) {…}”, there’s no need to put them inside #if as these blocks will be elided by the C++ compiler. That way the code will be less messy.

-------------

PR: https://git.openjdk.org/jdk/pull/12691