RFR: JDK-8302989: Add missing INCLUDE_CDS checks [v2]

[Matthias Baesken]

On Fri, 3 Mar 2023 01:13:18 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Hi Ioi, I adjusted the *SharedSpaces in  globalDefinitions.cpp / globalDefinitions.hpp  .
>
> I am on vacation now so I won’t be able to follow up with the review. Please feel free to integrate after you get enough reviews.
> 
> Just a general comment. For blocks that are enclosed with “if (UseSharedSpace) {…}”, there’s no need to put them inside #if as these blocks will be elided by the C++ compiler. That way the code will be less messy.

Hi Ioi, thanks for the feedback.  Mostly you are correct, the `#if`  blocks are not needed any more at most places. Should I remove them at least from my patch now or keep them?  But I think there are a few exceptions - at some places the coding attempts to set the *SharedSpaces flags and this does not compile any more after switching to const.  So there the  `#if`  blocks have to stay.

-------------

PR: https://git.openjdk.org/jdk/pull/12691