RFR: 8292059: Do not inline InstanceKlass::allocate_instance() [v2]

Afshin Zafari duke at openjdk.org
Fri Mar 3 11:58:17 UTC 2023


On Wed, 1 Mar 2023 12:38:59 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8292059: Do not inline InstanceKlass::allocate_instance()
>
> src/hotspot/share/oops/instanceKlass.inline.hpp line 188:
> 
>> 186: }
>> 187: 
>> 188: inline instanceOop InstanceKlass::allocate_instance(oop java_class, TRAPS) {
> 
> In moving this, can you eliminate any #includes at the top?  And migrate them to .cpp files that might need them.

All the #include headers are removed except the `utilities/devirtualizer.inline.hpp`. The .cpp files that need it should include it before `oops/instanceKlass.inline.hpp` which violates the _sorted header filename_ in the coding style rules.

-------------

PR: https://git.openjdk.org/jdk/pull/12782


More information about the hotspot-dev mailing list