RFR: 8292059: Do not inline InstanceKlass::allocate_instance() [v2]

Coleen Phillimore coleenp at openjdk.org
Fri Mar 3 16:57:23 UTC 2023


On Fri, 3 Mar 2023 11:55:14 GMT, Afshin Zafari <duke at openjdk.org> wrote:

>> src/hotspot/share/oops/instanceKlass.inline.hpp line 188:
>> 
>>> 186: }
>>> 187: 
>>> 188: inline instanceOop InstanceKlass::allocate_instance(oop java_class, TRAPS) {
>> 
>> In moving this, can you eliminate any #includes at the top?  And migrate them to .cpp files that might need them.
>
> All the #include headers are removed except the `utilities/devirtualizer.inline.hpp`. The .cpp files that need it should include it before `oops/instanceKlass.inline.hpp` which violates the _sorted header filename_ in the coding style rules.

Good.  I think devirtualizer.inline.hpp is used by the GC inlined functions so should remain here.

-------------

PR: https://git.openjdk.org/jdk/pull/12782


More information about the hotspot-dev mailing list