RFR: JDK-8302989: Add missing INCLUDE_CDS checks [v4]

[Matthias Baesken]

On Fri, 3 Mar 2023 08:55:07 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> The cds only coding in hotspot is usually guarded with the INCLUDE_CDS macro so that it can be removed at compile time in case the correct configure flags are set.
>> However at some places INCLUDE_CDS is missing and should be added.
>> 
>> One question - should (additionally to the UseSharedSpaces code section)  the DumpSharedSpaces code sections be guarded as well with INCLUDE_CDS macros ?
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adjust arguments handling

I noticed that  the  Xshare-handling IS already an issue on AIX - there cds is not supported and `-Xshare:off`  does not work.
So tests like the ones I mentioned in my list above e.g.

java/math/BigInteger/largeMemory/DivisionOverflow.java

all fail on AIX  (like on other platforms without cds).

-------------

PR: https://git.openjdk.org/jdk/pull/12691