RFR: 8304089: Convert TraceDependencies to UL [v3]

[David Holmes]

On Tue, 14 Mar 2023 15:40:53 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This change converts TraceDependencies to UL and removes the develop option. I think this provides further flexibility to add tags to only trace certain things in dependency analysis, as I did when trying to understand a PR for a deoptimization change.  For now, the messages are the same and the option is -Xlog:dependencies=debug.
>> Tested with tier1-4
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix merge conflict.

Overall looks good. Just a couple of small tweaks needed.

Thanks.

src/hotspot/share/runtime/arguments.cpp line 3589:

> 3587:       PrintCompilation || PrintInlining || PrintDependencies || PrintNativeNMethods ||
> 3588:       PrintDebugInfo || PrintRelocations || PrintNMethods || PrintExceptionHandlers ||
> 3589:       PrintAssembly || TraceDeoptimization || log_is_enabled(Debug, dependencies) ||

Now TraceDependencies is converted to UL I think it should just be deleted from this function. We don't need to enable LogVMOutput in that case.

src/hotspot/share/runtime/arguments.cpp line 4004:

> 4002:   bool trace_dependencies = log_is_enabled(Debug, dependencies);
> 4003:   if (trace_dependencies && VerifyDependencies) {
> 4004:     if (trace_dependencies) {

This inner if is not needed.

-------------

Changes requested by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/13007