RFR: 8304089: Convert TraceDependencies to UL [v3]

[Coleen Phillimore]

On Wed, 15 Mar 2023 02:49:54 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix merge conflict.
>
> src/hotspot/share/runtime/arguments.cpp line 3589:
> 
>> 3587:       PrintCompilation || PrintInlining || PrintDependencies || PrintNativeNMethods ||
>> 3588:       PrintDebugInfo || PrintRelocations || PrintNMethods || PrintExceptionHandlers ||
>> 3589:       PrintAssembly || TraceDeoptimization || log_is_enabled(Debug, dependencies) ||
> 
> Now TraceDependencies is converted to UL I think it should just be deleted from this function. We don't need to enable LogVMOutput in that case.

No, this is the right thing to do.  If -Xlog:dependency - the compiler group also expects the dependency printed to the compiler log file.  The logging is a separate mechanism, but should be enabled with -Xlog:dependency.

> src/hotspot/share/runtime/arguments.cpp line 4004:
> 
>> 4002:   bool trace_dependencies = log_is_enabled(Debug, dependencies);
>> 4003:   if (trace_dependencies && VerifyDependencies) {
>> 4004:     if (trace_dependencies) {
> 
> This inner if is not needed.

fixed, thanks.

-------------

PR: https://git.openjdk.org/jdk/pull/13007