RFR: 8292059: Do not inline InstanceKlass::allocate_instance() [v6]
Coleen Phillimore
coleenp at openjdk.org
Wed Mar 15 12:54:30 UTC 2023
On Fri, 3 Mar 2023 16:51:32 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> All the #include headers are removed except the `utilities/devirtualizer.inline.hpp`. The .cpp files that need it should include it before `oops/instanceKlass.inline.hpp` which violates the _sorted header filename_ in the coding style rules.
>
> Good. I think devirtualizer.inline.hpp is used by the GC inlined functions so should remain here.
Sorry for being confusing before. My comment was that you should remove #includes that aren't directly referenced by this .inline.hpp file. I see that you've done this now, but do you need classfile/vmSymbols.hpp here? I don't see it.
-------------
PR: https://git.openjdk.org/jdk/pull/12782
More information about the hotspot-dev
mailing list