RFR: 8304089: Convert TraceDependencies to UL [v3]

David Holmes dholmes at openjdk.org
Thu Mar 16 07:16:20 UTC 2023


On Wed, 15 Mar 2023 12:55:31 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/runtime/arguments.cpp line 3589:
>> 
>>> 3587:       PrintCompilation || PrintInlining || PrintDependencies || PrintNativeNMethods ||
>>> 3588:       PrintDebugInfo || PrintRelocations || PrintNMethods || PrintExceptionHandlers ||
>>> 3589:       PrintAssembly || TraceDeoptimization || log_is_enabled(Debug, dependencies) ||
>> 
>> Now TraceDependencies is converted to UL I think it should just be deleted from this function. We don't need to enable LogVMOutput in that case.
>
> No, this is the right thing to do.  If -Xlog:dependency - the compiler group also expects the dependency printed to the compiler log file.  The logging is a separate mechanism, but should be enabled with -Xlog:dependency.

Sorry I don't follow that. `use_vm_log()` only affects non-product builds and forces `LogVMOutput` to true. That in turn will cause `defaultStream::init_log()` to execute which initializes the log file etc. But I don't see how that would cause UL logging for "dependencies" to also get written to the log file???

-------------

PR: https://git.openjdk.org/jdk/pull/13007


More information about the hotspot-dev mailing list