RFR: 8302328: [s390x] Simplify asm_assert definition

Lutz Schmidt lucy at openjdk.org
Fri Mar 17 14:30:54 UTC 2023


On Thu, 2 Mar 2023 07:49:05 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

> This PR cleanups some assert statements and specifies branch condition at calling site itself. Remaining asm_assert methods are inlined as well.

Changes requested by lucy (Reviewer).

src/hotspot/cpu/s390/macroAssembler_s390.hpp line 870:

> 868: 
> 869:   // Assert if CC indicates "not equal" (check_equal==true) or "equal" (check_equal==false).
> 870:   inline void asm_assert(bool check_equal, const char* msg, int id) {

This will not work. Implementation of called method is not visible here. Need to move implementation to macroAssembler_s390.inline.hpp

-------------

PR: https://git.openjdk.org/jdk/pull/12822


More information about the hotspot-dev mailing list