RFR: 8302328: [s390x] Simplify asm_assert definition [v2]
Amit Kumar
amitkumar at openjdk.org
Wed Mar 29 16:59:47 UTC 2023
On Fri, 17 Mar 2023 08:56:01 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:
>> Amit Kumar has updated the pull request incrementally with five additional commits since the last revision:
>>
>> - added id to illtrap
>> - address lutz comment & revert inlining
>> - Revert "inline asm_assert"
>> - Revert "inlined assert method"
>> - Revert "added inline keyword before function implementation"
>
> src/hotspot/cpu/s390/stubRoutines_s390.cpp line 58:
>
>> 56: __ z_cgr(table, Z_R0); // safety net
>> 57: __ z_bre(L);
>> 58: __ z_illtrap();
>
> You should move z_illtrap() after asm_assert(). Not your fault!
@TheRealMDoerr here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/12822#discussion_r1152239779
More information about the hotspot-dev
mailing list