RFR: 8296440: Remove Method* handling from cleanup_inline_caches_impl [v2]

[Richard Reingruber]

On Mon, 20 Mar 2023 18:57:25 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Richard Reingruber has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - Adding TestStaticallyBoundTargetIsReachable.java
>>  - Path to target exists also if the receiver is a constant of the caller
>>  - Use nmethod::oops_do() to search for to_holder in from_nm
>>  - Merge branch 'master'
>>  - Remove MacroAssembler::resolve_weak_handle()
>>  - Remove keep_alive_offset() and holder_offset() from CLD
>>  - Remove MacroAssembler::load_method_holder_cld()
>>  - Remove c2i entry barrier
>>  - Check dependency for statically bound call
>
> src/hotspot/share/runtime/sharedRuntime.cpp line 1354:
> 
>> 1352: }
>> 1353: 
>> 1354: class Search2OopsClosure : public OopClosure {
> 
> Should this all be under #ifdef ASSERT?

Yes. I'll do that before the pr gets integrated.
I want to make sure all dependencies are present also in the release build.
(E.g. before JDK-8299155 was fixed the debug vm produced more dependencies)

> src/hotspot/share/runtime/sharedRuntime.cpp line 1418:
> 
>> 1416:         return; // `to` is reachable by iterating parents of `from`
>> 1417:       }
>> 1418:     }
> 
> I'd be happier if this part was a function in ClassLoaderData or refactored from record_dependency (along with the constains function).  Since it's similar code.

You are right. I've done the refactoring. Please let me know what you think.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12802#discussion_r1143738349
PR Review Comment: https://git.openjdk.org/jdk/pull/12802#discussion_r1143739466