RFR: 8296440: Remove Method* handling from cleanup_inline_caches_impl [v2]

Richard Reingruber rrich at openjdk.org
Tue Mar 21 17:16:38 UTC 2023


On Mon, 20 Mar 2023 19:01:21 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> I don't really know if this is right but some comments anyway.

Thanks for looking at this and for giving feedback.

> src/hotspot/share/classfile/classLoaderData.cpp line 791:
> 
>> 789: 
>> 790: bool ClassLoaderData::handles_contain(oop obj) {
>> 791:   return _handles.contains(obj);
> 
> This might need to be protected by a metaspace_lock.

I though it was not needed.
Looks like `ChunkedHandleList` supports unsynchronized reading. We might not see all the handles recently added without locking but we are guaranteed to see the handles that were added by resolving the call we are checking.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/12802#issuecomment-1478287839
PR Review Comment: https://git.openjdk.org/jdk/pull/12802#discussion_r1143745849


More information about the hotspot-dev mailing list