RFR: 8231349: Move intrinsic stubs generation to compiler runtime initialization code [v2]

Vladimir Kozlov kvn at openjdk.org
Thu Mar 23 00:37:47 UTC 2023


On Wed, 22 Mar 2023 23:05:04 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> So you want something similar to `COMPILER1_AND_COMPILER2_PRESENT()` used for `CodeCacheSegmentSize` in following line?
>> Yes, we have similar macro for JVMCI and C2. How about this:
>> 
>> define_pd_global(bool, MoveIntrinsicStubsGen,   false COMPILER2_OR_JVMCI_PRESENT( || true));
>
> What about the following?
> 
> define_pd_global(bool, MoveIntrinsicStubsGen,  NOT_COMPILER2_OR_JVMCI(false) COMPILER2_OR_JVMCI_PRESENT(true));
> 
> Are you concerned it is too long?
> 
> Or even `COMPILER2_OR_JVMCI` maybe?
> 
> define_pd_global(bool, MoveIntrinsicStubsGen, COMPILER2_OR_JVMCI);

Yes, I don't want long line. I will try the last suggestion. I was able to build locally with it on linux.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13096#discussion_r1145551383


More information about the hotspot-dev mailing list