RFR: 8302328: [s390x] Simplify asm_assert definition [v2]

[Martin Doerr]

On Wed, 29 Mar 2023 16:50:32 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> This PR cleanups some assert statements and specifies branch condition at calling site itself. Remaining asm_assert methods are inlined as well.
>
> Amit Kumar has updated the pull request incrementally with five additional commits since the last revision:
> 
>  - added id to illtrap
>  - address lutz comment & revert inlining
>  - Revert "inline asm_assert"
>  - Revert "inlined assert method"
>  - Revert "added inline keyword before function implementation"

src/hotspot/cpu/s390/stubRoutines_s390.cpp line 58:

> 56:     __ z_cgr(table, Z_R0);  // safety net
> 57:     __ z_bre(L);
> 58:     __ asm_assert(Assembler::bcondEqual, "crc_table: external word relocation required for load_absolute_address", 0x33);

How should this `asm_assert` ever get hit? It's preceded by a `bre.`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12822#discussion_r1152235506