RFR: 8303210: [linux, Windows] Make UseSystemMemoryBarrier available as product flag [v6]

David Holmes dholmes at openjdk.org
Thu Mar 30 00:40:20 UTC 2023


On Wed, 29 Mar 2023 10:43:33 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

> @dholmes: Thanks for reviewing! I had moved the flag initialization to `os::init_2()` because of your comment "Actually I think this code belongs in os::init() regardless.", but `os::init()` is too early. I actually agree with that somewhere in arguments.cpp would be nice, but I couldn't find a good place for it there.

Yeah I think I mistakenly thought this would only affect Linux - sorry. Duplicating in ` os::init2` on all platforms is not good. As for placement in arguments.cpp ... I would suggest adding a little function and calling it after `os::init_container_support()`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/12753#issuecomment-1489520985


More information about the hotspot-dev mailing list