RFR: JDK-8304815: Use NMT for more precise hs_err location printing [v4]
Thomas Stuefe
stuefe at openjdk.org
Thu Mar 30 06:17:11 UTC 2023
On Fri, 24 Mar 2023 11:44:47 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>>
>> More small fixes
>
> Thanks!
>
> I've got some requested changes, but I like it as a whole.
@jdksjolen Thank you for your review!
I took your suggested loop changes, but then changed them again to change the logic:
- if we find a live block, that's it
- if we find a dead block, we print it only if we don't find a better live block down the address range.
I also added tests for the dead case.
Manually tested on x64 and x86.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13162#issuecomment-1489752801
More information about the hotspot-dev
mailing list