RFR: JDK-8304815: Use NMT for more precise hs_err location printing [v4]

Thomas Stuefe stuefe at openjdk.org
Thu Mar 30 06:17:14 UTC 2023


On Fri, 24 Mar 2023 11:43:08 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> test/hotspot/gtest/nmt/test_nmt_locationprinting.cpp line 31:
>> 
>>> 29: #include "unittest.hpp"
>>> 30: 
>>> 31: //#define LOG_PLEASE
>> 
>> Outdated?
>
> Or meant as a hint?

I added a comment; one can uncomment the LOG_PLEASE for more test output (its a pragmatic thing I do in other gtests too). The macro lives in testUtils.hpp.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13162#discussion_r1152776850


More information about the hotspot-dev mailing list