RFR: 8297539: Use PrimitiveConversions::cast for local uses of the int<->float union conversion trick [v3]
David Holmes
dholmes at openjdk.org
Fri Mar 31 05:14:27 UTC 2023
On Tue, 28 Mar 2023 14:40:08 GMT, Afshin Zafari <duke at openjdk.org> wrote:
>> **Only** the instances of using `union` for converting `int` to `float` are replaced with call to `PrimitiveConversions::cast<To>(From)` method. Some few cases with conversion of `long` <->`double` are also replaced with `PrimitiveConversions::cast<To>(From)`. The other instances where the union contains other types of fields than `int` and `float` are left unchanged.
>>
>> ### Test
>> local hotspot:tier1
>> mach5 tiers 1-5
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>
> 8297539: Use PrimitiveConversions::cast for local uses of the int<->float union conversion trick
Seems okay other than the override issue.
Thanks.
-------------
PR Review: https://git.openjdk.org/jdk/pull/13136#pullrequestreview-1366261266
More information about the hotspot-dev
mailing list