RFR: 8297539: Use PrimitiveConversions::cast for local uses of the int<->float union conversion trick [v3]

Afshin Zafari duke at openjdk.org
Fri Mar 31 14:16:18 UTC 2023


On Tue, 28 Mar 2023 15:27:28 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8297539: Use PrimitiveConversions::cast for local uses of the int<->float union conversion trick
>
> src/hotspot/cpu/arm/assembler_arm.hpp line 288:
> 
>> 286:     override bool f_lo_is_null() const { return (_bits & ((1 << 19) - 1)) == 0; }
>> 287:     override int e() const { return ((_bits << 1) >> (23+1)) - 127; }
>> 288:     override unsigned int s() const { return _bits >> 31; }
> 
> This shouldn't compile? I think `override` should be after the declarator, so between `const` and the
> function body in all of these.

I fixed it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13136#discussion_r1154529947


More information about the hotspot-dev mailing list